Code reorganisation to use lag maps - #2
Merged
beccaclements99 merged 2 commits intoMar 12, 2026
Conversation
…dir is None check and reorganise lagged regression block
Merged
18 tasks
beccaclements99
merged commit Mar 12, 2026
d670ebd
into
beccaclements99:fix-lmap-option
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Necessary for smoia#154
This pull request adds informative logging throughout the
phys2cvrworkflow and refactors the lag map and regressor loading logic for clarity and robustness. The changes improve transparency of data loading steps, clarify the order of operations, and make lagged regression handling more explicit.Logging improvements:
Lag map and regression handling refactor:
Robustness improvements:
Performance and clarity: